[webkit-changes] [WebKit/WebKit] 87b382: Cherry-pick 276752 at main (75d98d9e2d74). https://bu...

Nikolas Zimmermann noreply at github.com
Mon Jun 17 05:17:49 PDT 2024 

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 87b38287cc33aadde3b0b823f265069e44dcc21f
      https://github.com/WebKit/WebKit/commit/87b38287cc33aadde3b0b823f265069e44dcc21f
  Author: Sosuke Suzuki <sosuke.suzuki at dr-ubie.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M JSTests/test262/expectations.yaml
    M Source/JavaScriptCore/builtins/ArrayConstructor.js

  Log Message:
  -----------
  Cherry-pick 276752 at main (75d98d9e2d74). https://bugs.webkit.org/show_bug.cgi?id=271703

    [JSC] Fix Array.fromAsync calls constructor twice
    https://bugs.webkit.org/show_bug.cgi?id=271703

    Reviewed by Yusuke Suzuki.

    This patch fixes a bug where calls like Array.fromAsync.call(MyArray, { length: 2, 0: 1, 1: 2 }); would cause MyArray constructor to be called twice.

    * JSTests/test262/expectations.yaml:
    * Source/JavaScriptCore/builtins/ArrayConstructor.js:
    (fromAsync):

    Canonical link: https://commits.webkit.org/276752@main

Canonical link: https://commits.webkit.org/274313.293@webkitglib/2.44


  Commit: 2a2b9886e6d8a2e40ac7cd4e9af00f13506cd531
      https://github.com/WebKit/WebKit/commit/2a2b9886e6d8a2e40ac7cd4e9af00f13506cd531
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M Source/JavaScriptCore/jit/JITCode.h

  Log Message:
  -----------
  Cherry-pick 276330 at main (5e89c8df137e). https://bugs.webkit.org/show_bug.cgi?id=271211

    Unreviewed, build fix after 271819 at main
    https://bugs.webkit.org/show_bug.cgi?id=271211
    rdar://124987262

    * Source/JavaScriptCore/jit/JITCode.h:

    Canonical link: https://commits.webkit.org/276330@main

Canonical link: https://commits.webkit.org/274313.294@webkitglib/2.44


  Commit: 0176943d61b498723134e0c1f86efc59e2a92535
      https://github.com/WebKit/WebKit/commit/0176943d61b498723134e0c1f86efc59e2a92535
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    M Source/WebCore/xml/XPathFunctions.cpp
    M Source/WebCore/xml/XPathPath.h
    M Source/WebCore/xml/XPathPredicate.cpp
    M Source/WebCore/xml/XPathPredicate.h
    M Source/WebCore/xml/XPathResult.cpp
    M Source/WebCore/xml/XPathValue.cpp
    M Source/WebCore/xml/XPathValue.h
    M Source/WebCore/xml/XPathVariableReference.h

  Log Message:
  -----------
  Cherry-pick 279506 at main (c4467fc5aed5). https://bugs.webkit.org/show_bug.cgi?id=274864

    WebCore::XPath::Value has uninitialized fields after construction
    <https://bugs.webkit.org/show_bug.cgi?id=274864>
    <rdar://128966823>

    Reviewed by Chris Dumez.

    Fix in XPathValue.h is to set m_bool and m_double to default values when
    constructing WebCore::XPath::Value objects.

    Additional drive-by fixes that comprise most of the changes:
    - Update WebCore::XPath::Value::Type to an enum class.
    - Fix format of header files to remove unwanted whitespace.
    - Add missing comments for closing namespace braces.
    - Fix indentation of case statements in XPathValue.cpp.
    - Fix formatting of constructors in XPathValue.h.

    * Source/WebCore/xml/XPathFunctions.cpp:
    * Source/WebCore/xml/XPathPath.h:
    * Source/WebCore/xml/XPathPredicate.cpp:
    (WebCore::XPath::predicateIsContextPositionSensitive):
    * Source/WebCore/xml/XPathPredicate.h:
    * Source/WebCore/xml/XPathResult.cpp:
    (WebCore::XPathResult::XPathResult):
    * Source/WebCore/xml/XPathValue.cpp:
    (WebCore::XPath::Value::modifiableNodeSet):
    (WebCore::XPath::Value::toBoolean const):
    (WebCore::XPath::Value::toNumber const):
    (WebCore::XPath::Value::toString const):
    * Source/WebCore/xml/XPathValue.h:
    (WebCore::XPath::Value):
    - Initialize m_bool to false and m_double to 0 to fix the bug.
    (WebCore::XPath::Value::Type):
    - Change to enum class with size uint8_t.
    - Remove redundant "Value" from the end of enum names.
    (WebCore::XPath::Value::Value):
    - Delete default constructor since it is unused.
    (WebCore::XPath::Value::type const):
    (WebCore::XPath::Value::isNodeSet const):
    (WebCore::XPath::Value::isBoolean const):
    (WebCore::XPath::Value::isNumber const):
    (WebCore::XPath::Value::isString const):
    (WebCore::XPath::Value::Data::create):
    (WebCore::XPath::Value::Data::Data):
    * Source/WebCore/xml/XPathVariableReference.h:

    Canonical link: https://commits.webkit.org/279506@main

Canonical link: https://commits.webkit.org/274313.295@webkitglib/2.44


  Commit: c20e01fab2a84df766e561a97cca7b1bc133452a
      https://github.com/WebKit/WebKit/commit/c20e01fab2a84df766e561a97cca7b1bc133452a
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    M Source/WebCore/xml/XPathParser.cpp

  Log Message:
  -----------
  Cherry-pick 279493 at main (ff290911a4c8). https://bugs.webkit.org/show_bug.cgi?id=274872

    WebCore::XPath::Parser::Token contains uninitialized fields after construction
    <https://bugs.webkit.org/show_bug.cgi?id=274872>
    <rdar://128972339>

    Reviewed by Chris Dumez.

    Merge individual token values into a std::variant<> type named
    TokenValue to make sure their initialized state and value are tracked
    properly.

    * Source/WebCore/xml/XPathParser.cpp:
    (WebCore::XPath::Parser::Token::TokenValue): Add.
    - Declare std::variant type to hold one of four possible values.
    (WebCore::XPath::Parser::Token::Token):
    - Replace four instance variables with TokenValue variable.
    - Delete default constructor since it is unused.
    - Condense constructors taking different value arguments into a single
      constructor taking a TokenValue (std::variant) r-value.
    (WebCore::XPath::Parser::Token::string): Add.
    (WebCore::XPath::Parser::Token::axis): Add.
    (WebCore::XPath::Parser::Token::numericOpcode): Add.
    (WebCore::XPath::Parser::Token::equalityTestOpcode): Add.
    - Add getter methods to read `value` instance variable.
    (WebCore::XPath::Parser::lex):
    - Update to use getter methods.

    Canonical link: https://commits.webkit.org/279493@main

Canonical link: https://commits.webkit.org/274313.296@webkitglib/2.44


  Commit: 11d5b6189348acd449b4a7fcfc1e5aa7477cd783
      https://github.com/WebKit/WebKit/commit/11d5b6189348acd449b4a7fcfc1e5aa7477cd783
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp

  Log Message:
  -----------
  Cherry-pick 279649 at main (86fbb6c7dafe). https://bugs.webkit.org/show_bug.cgi?id=274964

    [WPE][GTK] g_variant_builder_add_value: assertion 'GVSB(builder)->offset < GVSB(builder)->max_items' failed when encoding session state
    https://bugs.webkit.org/show_bug.cgi?id=274964

    Reviewed by Carlos Garcia Campos.

    When we encode the array of HTTP body elements, we have the open and
    close calls in the wrong place, such that it breaks if there are ever
    more than just one element.

    We could probably add a test for this, but it's not too likely to
    regress, and I didn't want to spend too long trying to work on that.

    * Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp:
    (encodeHTTPBody):

    Canonical link: https://commits.webkit.org/279649@main

Canonical link: https://commits.webkit.org/274313.297@webkitglib/2.44


  Commit: 046a09232f98a27189acc5787736e42b25a032b5
      https://github.com/WebKit/WebKit/commit/046a09232f98a27189acc5787736e42b25a032b5
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/RTCStatsReport.h

  Log Message:
  -----------
  Cherry-pick 279660 at main (44d522f49fae). https://bugs.webkit.org/show_bug.cgi?id=274976

    Many subclasses of WebCore::RTCStatsReport::Stats fail to initialize timestamp field
    <https://bugs.webkit.org/show_bug.cgi?id=274976>
    <rdar://129071458>

    Reviewed by Youenn Fablet.

    * Source/WebCore/Modules/mediastream/RTCStatsReport.h:
    (WebCore::RTCStatsReport::Stats::timestamp):
    - Add default initializer.

    Canonical link: https://commits.webkit.org/279660@main

Canonical link: https://commits.webkit.org/274313.298@webkitglib/2.44


  Commit: 1f371cdc68d7fec14fcee15c7e7ad6231c9a1a38
      https://github.com/WebKit/WebKit/commit/1f371cdc68d7fec14fcee15c7e7ad6231c9a1a38
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/WebCore/html/canvas/WebGLUtilities.h

  Log Message:
  -----------
  Cherry-pick 279549 at main (e39e0c613f32). https://bugs.webkit.org/show_bug.cgi?id=274858

    WebCore::ScopedInspectorShaderProgramHighlight constructor does not initialize struct m_savedBlend
    <https://bugs.webkit.org/show_bug.cgi?id=274858>
    <rdar://128962006>

    Reviewed by Dan Glastonbury.

    * Source/WebCore/html/canvas/WebGLUtilities.h:
    (WebCore::ScopedInspectorShaderProgramHighlight::m_savedBlend):
    - Add default initializers.

    Canonical link: https://commits.webkit.org/279549@main

Canonical link: https://commits.webkit.org/274313.299@webkitglib/2.44


  Commit: 420b61d5a0ad15839cedb30cb3c92139ab0aa30e
      https://github.com/WebKit/WebKit/commit/420b61d5a0ad15839cedb30cb3c92139ab0aa30e
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp

  Log Message:
  -----------
  Cherry-pick 279575 at main (1748da270165). https://bugs.webkit.org/show_bug.cgi?id=274959

    [WPE GTK Debug] API test `TestWebCore.MIMETypeRegistry.ExtensionsForMIMEType` is a constant crash
    https://bugs.webkit.org/show_bug.cgi?id=274959

    Reviewed by Carlos Garcia Campos.

    This patch implements `MIMETypeRegistry::extensionsForMIMEType`
    on Linux by using `xdg_mime_get_simple_globs()`.

    * Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp:
    (WebCore::MIMETypeRegistry::extensionsForMIMEType):

    Canonical link: https://commits.webkit.org/279575@main

Canonical link: https://commits.webkit.org/274313.300@webkitglib/2.44


  Commit: 47b5dc73c4b841ef8d0ce500da70eafcb65c6acd
      https://github.com/WebKit/WebKit/commit/47b5dc73c4b841ef8d0ce500da70eafcb65c6acd
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp
    M Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm

  Log Message:
  -----------
  Cherry-pick 279571 at main (34f75014ef73). https://bugs.webkit.org/show_bug.cgi?id=274927

    [GTK] UI process crash in gtk_accessible_update_children
    https://bugs.webkit.org/show_bug.cgi?id=274927

    Reviewed by Carlos Garcia Campos.

    We are failing to unparent the WebDataListSuggestionsDropdownGtk from
    the WebKitWebView before finalizing the web view. WebPageProxy calls
    WebDataListSuggestionsDropdown::close, but doesn't drop its ref until
    WebPageProxy::didCloseSuggestions is called. That happens in
    WebDataListSuggestionsDropdown::close, but the GTK implementation fails
    to chain up. Oops.

    I checked the color chooser and date/time picker widgets, which are
    implemented similarly, but didn't find any similar problem. I did notice
    that iOS also fails to chain up. It doesn't have this bug since it does
    the same work in the subclass instead, but it's surely safest to chain
    up here to be robust to future changes. Developers tend to get surprised
    when virtual function do not chain up.

    * Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
    (WebKit::WebDataListSuggestionsDropdownGtk::close):
    * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
    (WebKit::WebDataListSuggestionsDropdownIOS::close):

    Canonical link: https://commits.webkit.org/279571@main

Canonical link: https://commits.webkit.org/274313.301@webkitglib/2.44


  Commit: f2707497cf4aa4e9eaa64cf3f418f636aa409455
      https://github.com/WebKit/WebKit/commit/f2707497cf4aa4e9eaa64cf3f418f636aa409455
  Author: Marcus Plutowski <achierius at gmail.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARM64EAssembler.h

  Log Message:
  -----------
  Cherry-pick 278924 at main (924f61209bb0). https://bugs.webkit.org/show_bug.cgi?id=274321

    Fix MacroAssemblerARM64E to emit braaz, brabz correctly
    https://bugs.webkit.org/show_bug.cgi?id=274321
    rdar://128282890

    Reviewed by Keith Miller and Yusuke Suzuki.

    Previously `m_assembler.braaz` would actually emit blraaz, clobbering
    the link register.

    * Source/JavaScriptCore/assembler/ARM64EAssembler.h:
    (JSC::ARM64EAssembler::braaz):
    (JSC::ARM64EAssembler::brabz):

    Canonical link: https://commits.webkit.org/278924@main

Canonical link: https://commits.webkit.org/274313.302@webkitglib/2.44


  Commit: f33e07e76f31079ba3ca43871b5e7e0637e3f8aa
      https://github.com/WebKit/WebKit/commit/f33e07e76f31079ba3ca43871b5e7e0637e3f8aa
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M LayoutTests/fast/forms/form-validation.js
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/html/ValidatedFormListedElement.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  Cherry-pick 277069 at main (5eb211273e06). https://bugs.webkit.org/show_bug.cgi?id=263049

    REGRESSION ( Sonoma ): [ Sonoma w2 ] fast/forms/scroll-into-view-and-show-validation-message.html is a consistent failure.
    https://bugs.webkit.org/show_bug.cgi?id=263049

    Reviewed by Simon Fraser and Wenson Hsieh.

    The flakiness was caused by the race condition between callOnMainThread and rendering update. Namely, we sometimes fail
    to scroll to reveal before showing the validation bubble. Fixed the bug by aligning the validation bubble appearance to
    happen after rendering update in Page::doAfterUpdateRendering.

    * LayoutTests/fast/forms/form-validation.js:
    * LayoutTests/platform/mac-wk2/TestExpectations:
    * Source/WebCore/html/ValidatedFormListedElement.cpp:
    (WebCore::ValidatedFormListedElement::focusAndShowValidationMessage):
    * Source/WebCore/page/Page.cpp:
    (WebCore::Page::scheduleValidationMessageUpdate): Added.
    (WebCore::Page::updateValidationMessages): Added.
    (WebCore::Page::doAfterUpdateRendering):
    * Source/WebCore/page/Page.h:

    Canonical link: https://commits.webkit.org/277069@main

Canonical link: https://commits.webkit.org/274313.303@webkitglib/2.44


  Commit: be5647692340e7478916f0162c35b00a34e6c2a7
      https://github.com/WebKit/WebKit/commit/be5647692340e7478916f0162c35b00a34e6c2a7
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-06-13 (Thu, 13 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp

  Log Message:
  -----------
  Cherry-pick 279978 at main (e0c4addd008a). https://bugs.webkit.org/show_bug.cgi?id=275377

    [GTK] Fix texture leaks
    https://bugs.webkit.org/show_bug.cgi?id=275377

    Reviewed by Carlos Garcia Campos.

    * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
    (webkitWebViewBaseTakeViewSnapshot):
    * Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:
    (WebKit::ViewGestureController::beginSwipeGesture):

    Canonical link: https://commits.webkit.org/279978@main

Canonical link: https://commits.webkit.org/274313.304@webkitglib/2.44


  Commit: cf9ddb5095a811241b04321dc6bad64e207632ab
      https://github.com/WebKit/WebKit/commit/cf9ddb5095a811241b04321dc6bad64e207632ab
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/FunctionsGL.cpp

  Log Message:
  -----------
  Cherry-pick 280016 at main (86c1918fdd79). https://bugs.webkit.org/show_bug.cgi?id=275481

    [ANGLE] Protect from faulty GPU drivers, reporting nullptr as GL_EXTENSION string
    https://bugs.webkit.org/show_bug.cgi?id=275481

    Reviewed by Kimmo Kinnunen and Adrian Perez de Castro.

    On a particular i.MX8 board any WebGL demo crashes in ANGLE initialization,
    reporting a nullptr instead of a proper null-terminated string, when calling
    getStringIFunction(GL_EXTENSIONS, i) in libANGLEs GetIndexExtensions() method
    in renderer/gl/FunctionsGL.cpp. Null-check the string before trying to
    wrap it in a std::string.

    Covered by any WebGL test/demo on a certain i.MX8 board.

    * Source/ThirdParty/ANGLE/changes.diff:
    * Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/FunctionsGL.cpp:
    (rx::GetIndexedExtensions):

    Canonical link: https://commits.webkit.org/280016@main

Canonical link: https://commits.webkit.org/274313.305@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/52e428e37d6e...cf9ddb5095a8

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list