[webkit-changes] [WebKit/WebKit] 3cecaf: Rename TextIndicatorStyle to TextAnimation.

megangardner noreply at github.com
Sat Jun 15 23:37:32 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cecaf29a7bc9af7252286883e5504c387976a61
      https://github.com/WebKit/WebKit/commit/3cecaf29a7bc9af7252286883e5504c387976a61
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-06-15 (Sat, 15 Jun 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.h
    M Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.mm
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Scripts/webkit/messages.py
    A Source/WebKit/Shared/TextAnimationType.serialization.in
    R Source/WebKit/Shared/TextIndicatorStyle.serialization.in
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    A Source/WebKit/UIProcess/Cocoa/WKTextAnimationType.h
    R Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
    M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/PageClient.h
    A Source/WebKit/UIProcess/TextAnimationType.h
    R Source/WebKit/UIProcess/TextIndicatorStyle.h
    A Source/WebKit/UIProcess/WKSTextAnimationManager.h
    R Source/WebKit/UIProcess/WKSTextStyleManager.h
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    A Source/WebKit/UIProcess/mac/WKTextAnimationManager.h
    A Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm
    R Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h
    R Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    A Source/WebKit/WebKitSwift/TextAnimation/TextAnimationManager.swift
    A Source/WebKit/WebKitSwift/TextAnimation/WKSTextAnimationSourceDelegate.h
    A Source/WebKit/WebKitSwift/TextAnimation/WKSTextStyleSourceDelegate.h
    R Source/WebKit/WebKitSwift/TextIndicatorStyle/TextStyleManager.swift
    R Source/WebKit/WebKitSwift/TextIndicatorStyle/WKSTextStyleSourceDelegate.h
    M Source/WebKit/WebKitSwift/WebKitSwift.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    A Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm
    R Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
    A Source/WebKit/WebProcess/WebPage/TextAnimationController.h
    R Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Rename TextIndicatorStyle to TextAnimation.
https://bugs.webkit.org/show_bug.cgi?id=275517
rdar://129878612

Reviewed by Richard Robinson.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/page/ChromeClient.h:
(WebCore::ChromeClient::removeTextAnimationForID):
(WebCore::ChromeClient::cleanUpTextAnimationsForSessionID):
(WebCore::ChromeClient::addSourceTextAnimation):
(WebCore::ChromeClient::addDestinationTextAnimation):
(WebCore::ChromeClient::removeTextIndicatorStyleForID): Deleted.
(WebCore::ChromeClient::cleanUpTextStylesForSessionID): Deleted.
(WebCore::ChromeClient::addSourceTextIndicatorStyle): Deleted.
(WebCore::ChromeClient::addDestinationTextIndicatorStyle): Deleted.
* Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.h:
* Source/WebCore/page/unified-text-replacement/UnifiedTextReplacementController.mm:
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):
(WebCore::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange):
(WebCore::UnifiedTextReplacementController::didEndTextReplacementSession):
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/TextAnimationType.serialization.in: Renamed from Source/WebKit/Shared/TextIndicatorStyle.serialization.in.
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(toWKTextAnimationType):
(-[WKWebView _addTextAnimationTypeForID:withData:]):
(-[WKWebView _removeTextAnimationForID:]):
(-[WKWebView _enableTextIndicatorStylingAfterElementWithID:]):
(-[WKWebView _enableTextIndicatorStylingForElementWithID:]):
(-[WKWebView _disableTextIndicatorStylingWithUUID:]):
(-[WKWebView _enableSourceTextAnimationAfterElementWithID:]):
(-[WKWebView _enableFinalTextAnimationForElementWithID:]):
(-[WKWebView _disableTextAnimationWithUUID:]):
(toWKTextIndicatorStyleType): Deleted.
(-[WKWebView _addTextIndicatorStyleForID:withData:]): Deleted.
(-[WKWebView _removeTextIndicatorStyleForID:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::addTextAnimationTypeForID):
(WebKit::PageClientImplCocoa::removeTextAnimationForID):
(WebKit::PageClientImplCocoa::addTextIndicatorStyleForID): Deleted.
(WebKit::PageClientImplCocoa::removeTextIndicatorStyleForID): Deleted.
* Source/WebKit/UIProcess/Cocoa/WKTextAnimationType.h: Renamed from Source/WebKit/UIProcess/Cocoa/WKTextIndicatorStyleType.h.
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::enableSourceTextAnimationAfterElementWithID):
(WebKit::WebPageProxy::enableTextAnimationTypeForElementWithID):
(WebKit::WebPageProxy::addTextAnimationTypeForID):
(WebKit::WebPageProxy::getTextIndicatorForID):
(WebKit::WebPageProxy::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::WebPageProxy::removeTextAnimationForID):
(WebKit::WebPageProxy::enableTextIndicatorStyleAfterElementWithID): Deleted.
(WebKit::WebPageProxy::enableTextIndicatorStyleForElementWithID): Deleted.
(WebKit::WebPageProxy::addTextIndicatorStyleForID): Deleted.
(WebKit::WebPageProxy::updateTextIndicatorStyleVisibilityForID): Deleted.
(WebKit::WebPageProxy::removeTextIndicatorStyleForID): Deleted.
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/TextAnimationType.h: Renamed from Source/WebKit/UIProcess/TextIndicatorStyle.h.
* Source/WebKit/UIProcess/WKSTextAnimationManager.h: Renamed from Source/WebKit/UIProcess/WKSTextStyleManager.h.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView addTextAnimationTypeForID:withStyleType:]):
(-[WKContentView removeTextAnimationForID:]):
(-[WKContentView updateUnderlyingTextVisibilityForTextAnimationID:visible:completionHandler:]):
(-[WKContentView containingViewForTextAnimationType]):
(-[WKContentView addTextIndicatorStyleForID:withStyleType:]): Deleted.
(-[WKContentView removeTextIndicatorStyleForID:]): Deleted.
(-[WKContentView updateTextIndicatorStyleVisibilityForID:visible:completionHandler:]): Deleted.
(-[WKContentView containingViewForTextIndicatorStyle]): Deleted.
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.h: Renamed from Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.h.
* Source/WebKit/UIProcess/mac/WKTextAnimationManager.mm: Renamed from Source/WebKit/UIProcess/mac/WKTextIndicatorStyleManager.mm.
(-[WKTextAnimationTypeEffectData initWithEffectID:type:]):
(-[WKTextAnimationTypeEffectData effectID]):
(-[WKTextAnimationManager initWithWebViewImpl:]):
(-[WKTextAnimationManager addTextAnimationTypeForID:withData:]):
(-[WKTextAnimationManager removeTextAnimationForID:]):
(-[WKTextAnimationManager hasActiveTextAnimationType]):
(-[WKTextAnimationManager suppressTextAnimationType]):
(-[WKTextAnimationManager restoreTextAnimationType]):
(-[WKTextAnimationManager textPreviewsForChunk:completion:]):
(-[WKTextAnimationManager textPreviewForRect:completion:]):
(-[WKTextAnimationManager updateIsTextVisible:forChunk:completion:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::hasContentRelativeChildViews const):
(WebKit::WebViewImpl::suppressContentRelativeChildViews):
(WebKit::WebViewImpl::restoreContentRelativeChildViews):
(WebKit::WebViewImpl::addTextAnimationTypeForID):
(WebKit::WebViewImpl::removeTextAnimationForID):
(WebKit::WebViewImpl::addTextIndicatorStyleForID): Deleted.
(WebKit::WebViewImpl::removeTextIndicatorStyleForID): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/TextAnimation/TextAnimationManager.swift: Copied from Source/WebKit/WebKitSwift/TextIndicatorStyle/TextStyleManager.swift.
(currentEffect):
(delegate):
(beginEffect(for:style:)):
(endEffect(for:)):
(TextAnimationManager.targetedPreview(for:)):
(TextAnimationManager.updateTextChunkVisibilityForAnimation(_:visible:)):
(TextAnimationManager.performReplacementAndGeneratePreview(for:effect:animation:)):
(TextAnimationManager.replacementEffectDidComplete(_:)):
* Source/WebKit/WebKitSwift/TextAnimation/TextStyleManager.swift: Renamed from Source/WebKit/WebKitSwift/TextIndicatorStyle/TextStyleManager.swift.
(currentEffect):
(delegate):
(beginEffect(for:style:)):
(endEffect(for:)):
(TextAnimationManager.targetedPreview(for:)):
(TextAnimationManager.updateTextChunkVisibilityForAnimation(_:visible:)):
(TextAnimationManager.performReplacementAndGeneratePreview(for:effect:animation:)):
(TextAnimationManager.replacementEffectDidComplete(_:)):
* Source/WebKit/WebKitSwift/TextAnimation/WKSTextAnimationSourceDelegate.h: Copied from Source/WebKit/WebKitSwift/TextIndicatorStyle/WKSTextStyleSourceDelegate.h.
* Source/WebKit/WebKitSwift/TextAnimation/WKSTextStyleSourceDelegate.h: Renamed from Source/WebKit/WebKitSwift/TextIndicatorStyle/WKSTextStyleSourceDelegate.h.
* Source/WebKit/WebKitSwift/WebKitSwift.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::removeTextAnimationForID):
(WebKit::WebChromeClient::cleanUpTextAnimationsForSessionID):
(WebKit::WebChromeClient::addSourceTextAnimation):
(WebKit::WebChromeClient::addDestinationTextAnimation):
(WebKit::WebChromeClient::removeTextIndicatorStyleForID): Deleted.
(WebKit::WebChromeClient::cleanUpTextStylesForSessionID): Deleted.
(WebKit::WebChromeClient::addSourceTextIndicatorStyle): Deleted.
(WebKit::WebChromeClient::addDestinationTextIndicatorStyle): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm: Renamed from Source/WebKit/WebProcess/WebPage/Cocoa/TextIndicatorStyleController.mm.
(WebKit::TextAnimationController::TextAnimationController):
(WebKit::TextAnimationController::document const):
(WebKit::TextAnimationController::contextRangeForSessionWithID const):
(WebKit::TextAnimationController::contextRangeForTextAnimationType const):
(WebKit::TextAnimationController::cleanUpTextAnimationsForSessionID):
(WebKit::TextAnimationController::removeTransparentMarkersForTextAnimationID):
(WebKit::newlyReplacedCharacterRange):
(WebKit::TextAnimationController::addSourceTextAnimation):
(WebKit::TextAnimationController::addDestinationTextAnimation):
(WebKit::TextAnimationController::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::TextAnimationController::createTextIndicatorForRange):
(WebKit::TextAnimationController::createTextIndicatorForTextAnimationID):
(WebKit::TextAnimationController::enableSourceTextAnimationAfterElementWithID):
(WebKit::TextAnimationController::enableTextAnimationTypeForElementWithID):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::createTextIndicatorForTextAnimationID):
(WebKit::WebPage::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::WebPage::enableSourceTextAnimationAfterElementWithID):
(WebKit::WebPage::enableTextAnimationTypeForElementWithID):
(WebKit::WebPage::createTextIndicatorForID): Deleted.
(WebKit::WebPage::updateTextIndicatorStyleVisibilityForID): Deleted.
(WebKit::WebPage::enableTextIndicatorStyleAfterElementWithID): Deleted.
(WebKit::WebPage::enableTextIndicatorStyleForElementWithID): Deleted.
* Source/WebKit/WebProcess/WebPage/TextAnimationController.h: Renamed from Source/WebKit/WebProcess/WebPage/TextIndicatorStyleController.h.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):
(WebKit::WebPage::addTextAnimationTypeForID):
(WebKit::WebPage::removeTextAnimationForID):
(WebKit::WebPage::cleanUpTextAnimationsForSessionID):
(WebKit::WebPage::addSourceTextAnimation):
(WebKit::WebPage::addDestinationTextAnimation):
(WebKit::m_textIndicatorStyleController): Deleted.
(WebKit::WebPage::addTextIndicatorStyleForID): Deleted.
(WebKit::WebPage::removeTextIndicatorStyleForID): Deleted.
(WebKit::WebPage::cleanUpTextStylesForSessionID): Deleted.
(WebKit::WebPage::addSourceTextIndicatorStyle): Deleted.
(WebKit::WebPage::addDestinationTextIndicatorStyle): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/280060@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list