[webkit-changes] [WebKit/WebKit] 1048a8: [JSC] Clean up Handler IC related conditions

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1048a88392df0f3ea65598cdd94cfc20e4d978b4
      https://github.com/WebKit/WebKit/commit/1048a88392df0f3ea65598cdd94cfc20e4d978b4
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-06-14 (Fri, 14 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
    M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h

  Log Message:
  -----------
  [JSC] Clean up Handler IC related conditions
https://bugs.webkit.org/show_bug.cgi?id=275515
rdar://129877540

Reviewed by Yijia Huang.

1. Remove Options::useHandlerIC() check in generateSlowPathHandler. It is not necessary.
2. Make viaGlobalProxy condition solid. We add assertions to make them explicit.
3. Remove unnecessary currStructure condition check in ProxyObjectLoad.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::canBeViaGlobalProxy):
(JSC::InlineCacheCompiler::generateSlowPathHandler):
(JSC::InlineCacheCompiler::generateWithGuard):
(JSC::InlineCacheCompiler::generateAccessCase):
(JSC::InlineCacheCompiler::compileOneAccessCaseHandler):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:

Canonical link: https://commits.webkit.org/280043@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications