[webkit-changes] [WebKit/WebKit] 3963a9: [WebGPU] Exception thrown in Queue::commandBufferW...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3963a92c82c11694752a00d0050cc3168b2a73c8
      https://github.com/WebKit/WebKit/commit/3963a92c82c11694752a00d0050cc3168b2a73c8
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  -----------
  [WebGPU] Exception thrown in Queue::commandBufferWithDescriptor when newSharedEvent returns nil
https://bugs.webkit.org/show_bug.cgi?id=275417
<radar://129708391>

Reviewed by Dan Glastonbury.

It is unclear why newSharedEvent returns nil, but I have seen it occur
occassionally running http://chat.webllm.ai

There is no harm not creating the shared event, but the command buffer will
needlessly stay around until it reaches zero references and ARC deallocs it,
but only for command buffers which are not committed.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commandBufferWithDescriptor):

Canonical link: https://commits.webkit.org/279975@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications