[webkit-changes] [WebKit/WebKit] 007289: [Win][MiniBrowser] Rounding fractional device scal...

[Kohei Asano]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 007289d10afb4e15f07fbef9135148b4e81bfdc2
      https://github.com/WebKit/WebKit/commit/007289d10afb4e15f07fbef9135148b4e81bfdc2
  Author: Kohei Asano <Kohei.Asano at sony.com>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Tools/MiniBrowser/win/BrowserWindow.h
    M Tools/MiniBrowser/win/MainWindow.cpp
    M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
    M Tools/MiniBrowser/win/WebKitBrowserWindow.h

  Log Message:
  -----------
  [Win][MiniBrowser] Rounding fractional device scale factor
https://bugs.webkit.org/show_bug.cgi?id=275420

Reviewed by Fujii Hironori.

Non-integral device scale factor is possible on Windows, although it
isn't on other platform e.g. Mac or GTK.
Using fractional device scale factor isn't supported by current WebKit,
rendering noises remain when repainting display.

So far, we set custom device scale factor value 1 and used zoom factor
instead of device scale factor to avoid these noises.
But using zoom factor doesn't scale scroll bar width, it seems weird
especially on high DPI. It's better to round device scale factor,
scale the contents based on integral device scale factor
and let MiniBrowser adjust by page zoom factor.

* Source/WebKit/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
* Tools/MiniBrowser/win/BrowserWindow.h:
* Tools/MiniBrowser/win/MainWindow.cpp:
* Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:
* Tools/MiniBrowser/win/WebKitBrowserWindow.h:

Canonical link: https://commits.webkit.org/279967@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications