[webkit-changes] [WebKit/WebKit] 0ca9ea: [WebGPU] maxComputeWorkgroupStorageSize in WGSL va...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ca9eaa9a4db9aaa2a67c01af2c37fa694fe60f9
      https://github.com/WebKit/WebKit/commit/0ca9eaa9a4db9aaa2a67c01af2c37fa694fe60f9
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] maxComputeWorkgroupStorageSize in WGSL validation should come from the WebGPU Device
https://bugs.webkit.org/show_bug.cgi?id=275408
<radar://129694407>

Reviewed by Tadeu Zagallo.

The WGSL specification says 16384 is the smallest value possible,
which maps to the default limit in WebGPU. However, a WebGPU device
created with a larger value should honor the larger value during compilation.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):

Canonical link: https://commits.webkit.org/279960@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications