[webkit-changes] [WebKit/WebKit] 52f67b: Local WebKit builds don't use locally-built WebKit...

Per Arne Vollan noreply at github.com
Wed Jun 12 07:22:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52f67b99e6e8949eb858922e818472f4a3089625
      https://github.com/WebKit/WebKit/commit/52f67b99e6e8949eb858922e818472f4a3089625
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-06-12 (Wed, 12 Jun 2024)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements
    M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Local WebKit builds don't use locally-built WebKit process extensions
https://bugs.webkit.org/show_bug.cgi?id=273550
rdar://125726458

Reviewed by Elliott Williams.

When locally built WebKit extensions are installed in the app bundle, these extensions
will be launched instead of the system extensions when launching said app. This patch
adds a build step that copies extensions to WebKitTestRunner app bundle.

* Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::isInWebKitChildProcess):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::hasExtensionInAppBundle):
(WebKit::launchWithExtensionKit):
* Tools/Scripts/webkitpy/port/device_port.py:
(DevicePort._install_extensions):
(DevicePort._install):
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/279946@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list