[webkit-changes] [WebKit/WebKit] 2234ec: Crash under WebKit::WebExtensionContext::didMoveTab.

Timothy Hatcher noreply at github.com
Tue Jun 11 15:19:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2234ec7559e04c7ce9ea2cf6bd40ff717e8264f2
      https://github.com/WebKit/WebKit/commit/2234ec7559e04c7ce9ea2cf6bd40ff717e8264f2
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  -----------
  Crash under WebKit::WebExtensionContext::didMoveTab.
https://webkit.org/b/275374
rdar://129507386

Reviewed by Brian Weinstein.

Add a null check for newWindow, since if both newWindow and oldWindow are null
we will follow the first case and try to deference newWindow accessing identifier().

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::didMoveTab):

Canonical link: https://commits.webkit.org/279928@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list