[webkit-changes] [WebKit/WebKit] ea2135: CanvasBase contains 2D context specific drawing me...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea2135ab14ff38d8adaa16c94ee1666c4b9ff2dd
      https://github.com/WebKit/WebKit/commit/ea2135ab14ff38d8adaa16c94ee1666c4b9ff2dd
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/html/CanvasBase.cpp
    M Source/WebCore/html/CanvasBase.h
    M Source/WebCore/html/CustomPaintCanvas.cpp
    M Source/WebCore/html/CustomPaintCanvas.h
    M Source/WebCore/html/HTMLCanvasElement.h
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
    M Source/WebCore/html/canvas/PaintRenderingContext2D.cpp
    M Source/WebCore/html/canvas/PaintRenderingContext2D.h

  Log Message:
  -----------
  CanvasBase contains 2D context specific drawing methods
https://bugs.webkit.org/show_bug.cgi?id=274750
rdar://128788730

Reviewed by Said Abou-Hallawa.

Move drawingContext(), existingDrawingContext(), baseTransform() to
CanvasRenderingContext2DBase as they are only related to 2D context
implementation.

This is work towards CanvasRenderingContext subclasses themselves managing
the copied buffers.

* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::drawingContext const): Deleted.
(WebCore::CanvasBase::existingDrawingContext const): Deleted.
(WebCore::CanvasBase::baseTransform const): Deleted.
* Source/WebCore/html/CanvasBase.h:
(WebCore::CanvasBase::hasCreatedImageBuffer const):
* Source/WebCore/html/CustomPaintCanvas.cpp:
(WebCore::CustomPaintCanvas::getContext):
(WebCore::CustomPaintCanvas::replayDisplayList):
(WebCore::CustomPaintCanvas::copiedImage const):
(WebCore::CustomPaintCanvas::baseTransform const): Deleted.
(WebCore::CustomPaintCanvas::drawingContext const): Deleted.
(WebCore::CustomPaintCanvas::existingDrawingContext const): Deleted.
(WebCore::CustomPaintCanvas::replayDisplayListImpl const): Deleted.
* Source/WebCore/html/CustomPaintCanvas.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::unwindStateStack):
(WebCore::CanvasRenderingContext2DBase::isAccelerated const):
(WebCore::CanvasRenderingContext2DBase::reset):
(WebCore::CanvasRenderingContext2DBase::resetTransform):
(WebCore::CanvasRenderingContext2DBase::clearCanvas):
(WebCore::CanvasRenderingContext2DBase::transformAreaToDevice const):
(WebCore::CanvasRenderingContext2DBase::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2DBase::compositeBuffer):
(WebCore::CanvasRenderingContext2DBase::didDraw):
(WebCore::CanvasRenderingContext2DBase::drawingContext const):
(WebCore::CanvasRenderingContext2DBase::existingDrawingContext const):
(WebCore::CanvasRenderingContext2DBase::baseTransform const):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebCore/html/canvas/PaintRenderingContext2D.cpp:
(WebCore::PaintRenderingContext2D::create):
(WebCore::PaintRenderingContext2D::PaintRenderingContext2D):
(WebCore::PaintRenderingContext2D::canvas const):
(WebCore::PaintRenderingContext2D::drawingContext const):
(WebCore::PaintRenderingContext2D::existingDrawingContext const):
(WebCore::PaintRenderingContext2D::baseTransform const):
(WebCore::PaintRenderingContext2D::replayDisplayList const):
* Source/WebCore/html/canvas/PaintRenderingContext2D.h:

Canonical link: https://commits.webkit.org/279912@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications