[webkit-changes] [WebKit/WebKit] 774209: Allow top layer elements to be nested within popovers

Keith Cirkel noreply at github.com
Mon Jun 10 06:24:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7742091ae26092602ec5cfe5acff453f0430cacb
      https://github.com/WebKit/WebKit/commit/7742091ae26092602ec5cfe5acff453f0430cacb
  Author: Keith Cirkel <webkit at keithcirkel.co.uk>
  Date:   2024-06-10 (Mon, 10 Jun 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-anchor.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-hints.tentative-expected.txt
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  Allow top layer elements to be nested within popovers
https://bugs.webkit.org/show_bug.cgi?id=269928

Reviewed by Tim Nguyen.

This implements the changes to the spec as defined by
https://github.com/whatwg/html/pull/10116

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-anchor.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-hints.tentative-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::topmostPopoverAncestor):
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::willEnterFullscreen):
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::showPopover):
(WebCore::topmostPopoverAncestor): Deleted.

Canonical link: https://commits.webkit.org/279874@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list