[webkit-changes] [WebKit/WebKit] 77966f: [visionOS] no VP8 or VP9 available in visionOS VM.

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77966f5b8e272f8b790a223fc21c036dcf857b1c
      https://github.com/WebKit/WebKit/commit/77966f5b8e272f8b790a223fc21c036dcf857b1c
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M LayoutTests/media/vp9.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
    M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
    M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
    M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h
    M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm
    M Source/WebKit/GPUProcess/GPUProcess.cpp
    M Source/WebKit/GPUProcess/GPUProcess.h
    M Source/WebKit/GPUProcess/GPUProcessPreferences.cpp
    M Source/WebKit/GPUProcess/GPUProcessPreferences.h
    M Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  [visionOS] no VP8 or VP9 available in visionOS VM.
https://bugs.webkit.org/show_bug.cgi?id=275204
rdar://129329733

Reviewed by Youenn Fablet.

VP8 and VP9 codecs are currently not available on visionOS VM making testing difficult.
The actual hardware has HW acceleration for VP9 and VP8 is available in VideoToolbox.

We add an internal web preference to always enable software decoders.
On machines with no VP8/VP9 decoder we will fallback on the WebCoreDecompressionSession and
the WebRTC software decoders.

There's no current testing infrastructure for this configuration.
The underlying bug is tracked under
rdar://129329733

* LayoutTests/media/vp9.html: rename preference.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setSWDecoderAlwaysEnabled):
(WebCore::PlatformMediaSessionManager::swDecoderAlwaysEnabled):
(WebCore::PlatformMediaSessionManager::setShouldEnableVP9SWDecoder): Deleted.
(WebCore::PlatformMediaSessionManager::shouldEnableVP9SWDecoder): Deleted.
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::ensureCodecsRegistered):
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::VP9TestingOverrides::setSWDecoderAlwaysEnabled):
(WebCore::isSWDecoderAlwaysEnabled):
(WebCore::isVP9DecoderAvailable):
(WebCore::isVP8DecoderAvailable):
(WebCore::isVP9CodecConfigurationRecordSupported):
(WebCore::computeVPParameters):
* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::updateGPUProcessPreferences):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcessPreferences.cpp:
(WebKit::GPUProcessPreferences::copyEnabledWebPreferences):
* Source/WebKit/GPUProcess/GPUProcessPreferences.h:
* Source/WebKit/GPUProcess/GPUProcessPreferences.serialization.in:
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_unifiedTextReplacementController):

Canonical link: https://commits.webkit.org/279806@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications