[webkit-changes] [WebKit/WebKit] ccb2f0: dataLogIf should check the condition is a bool or ...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccb2f0d494326452b30f8f40174d5195e60e5e49
      https://github.com/WebKit/WebKit/commit/ccb2f0d494326452b30f8f40174d5195e60e5e49
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmStreamingParser.cpp
    M Source/WTF/wtf/DataLog.h

  Log Message:
  -----------
  dataLogIf should check the condition is a bool or enum
https://bugs.webkit.org/show_bug.cgi?id=275155
rdar://problem/129280739

Reviewed by Justin Michaud.

I often make the mistake of accidentally writing `dataLogIf("thing I want to log");`
Which is probably not what people intended. This patch adds some simple validation
to make that harder.

* Source/JavaScriptCore/wasm/WasmStreamingParser.cpp:
(JSC::Wasm::StreamingParser::StreamingParser):
* Source/WTF/wtf/DataLog.h:

Canonical link: https://commits.webkit.org/279753@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications