[webkit-changes] [WebKit/WebKit] 6d7020: [WebGPU] Vertex buffers used in a drawIndexed call...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d7020a4d4805edbfc3c260e8e56dcc8fbf5a7bb
      https://github.com/WebKit/WebKit/commit/6d7020a4d4805edbfc3c260e8e56dcc8fbf5a7bb
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
    M LayoutTests/fast/webgpu/regression/repro_274703-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275024-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275024.html
    A LayoutTests/fast/webgpu/regression/repro_275024b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275024b.html
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Vertex buffers used in a drawIndexed call are not validated for vertex step mode
https://bugs.webkit.org/show_bug.cgi?id=275024
<radar://129058740>

Reviewed by Dan Glastonbury.

A vertex buffer must be at least the size of one vertex in any draw
call, if it is used by the shader.

* LayoutTests/fast/webgpu/regression/repro_274703-expected.txt:
* LayoutTests/fast/webgpu/regression/repro_275024-expected.txt: Copied from LayoutTests/fast/webgpu/regression/repro_274703-expected.txt.
* LayoutTests/fast/webgpu/regression/repro_275024.html: Added.
* LayoutTests/fast/webgpu/regression/repro_275024b-expected.txt: Copied from LayoutTests/fast/webgpu/regression/repro_274703-expected.txt.
* LayoutTests/fast/webgpu/regression/repro_275024b.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):

Canonical link: https://commits.webkit.org/279708@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications