[webkit-changes] [WebKit/WebKit] 858f09: [WebGPU] white screen on noclip.website

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 858f0966395a8de999845daa1e576eb4b724fce7
      https://github.com/WebKit/WebKit/commit/858f0966395a8de999845daa1e576eb4b724fce7
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_275043-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275043.html
    A LayoutTests/fast/webgpu/regression/repro_275043b-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275043b.html
    A LayoutTests/fast/webgpu/regression/repro_275043c-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_275043c.html
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] white screen on noclip.website
https://bugs.webkit.org/show_bug.cgi?id=275043
<radar://129051291>

Reviewed by Dan Glastonbury.

colorAttachmentViews could contain nil entries, which were not accounted for.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::colorDepthStencilTargetsMatch const):
(WebGPU::RenderPipeline::validateRenderBundle const):

* LayoutTests/fast/webgpu/regression/repro_275043-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275043.html: Added.
* LayoutTests/fast/webgpu/regression/repro_275043b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275043b.html: Added.
* LayoutTests/fast/webgpu/regression/repro_275043c-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_275043c.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::colorDepthStencilTargetsMatch const):
(WebGPU::RenderPipeline::validateRenderBundle const):

Canonical link: https://commits.webkit.org/279704@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications