[webkit-changes] [WebKit/WebKit] 83e87b: Allow speculative parser to see inside Declarative...

Commit Queue noreply at github.com
Mon Jun 3 12:31:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83e87b6e6a3beda3ed62ced43e7dc01aaf44d327
      https://github.com/WebKit/WebKit/commit/83e87b6e6a3beda3ed62ced43e7dc01aaf44d327
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-img-src.tentative.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-link-stylesheet.tentative.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-script-src.tentative.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-img-src.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-link-stylesheet.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-script-src.tentative-expected.txt
    M Source/WebCore/html/parser/HTMLPreloadScanner.cpp

  Log Message:
  -----------
  Allow speculative parser to see inside Declarative Shadow DOM (DSD) templates

https://bugs.webkit.org/show_bug.cgi?id=269697
rdar://problem/123623233

Reviewed by Antti Koivisto.

Merge: https://chromium-review.googlesource.com/c/chromium/src/+/4200836

Prior to this patch, the speculative parser would bail out at the sight
of any `template` element. However, if that template was a
Declarative Shadow DOM shadow root, like `template shadowrootmode=open`,
it should be scanned.

Note that DSD shadow roots inside "normal" template elements
should still be skipped, since everything in the `template`
is inert.

* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan):
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-img-src.tentative.sub-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-link-stylesheet.tentative.sub-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-script-src.tentative.sub-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-img-src.tentative-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-link-stylesheet.tentative-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-shadowrootmode-script-src.tentative-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/279668@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list