[webkit-changes] [WebKit/WebKit] 5a264d: [WebXR] Add a reason for ending XRSessions

Ada Chan noreply at github.com
Mon Jun 3 09:37:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a264de1c9901a61c3826532df73319b334d3ebc
      https://github.com/WebKit/WebKit/commit/5a264de1c9901a61c3826532df73319b334d3ebc
  Author: Ada Chan <adachan at apple.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIUIClient.h
    M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    A Source/WebKit/UIProcess/XR/PlatformXRSessionEnums.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WebXR] Add a reason for ending XRSessions
https://bugs.webkit.org/show_bug.cgi?id=275015
rdar://127837175

Reviewed by Kimmo Kinnunen and Mike Wyrzykowski.

API::UIClient::endXRSession() now takes in a new WebKit::PlatformXRSessionEndReason
parameter so we can differentiate between the normal and error cases for
the session termination.

* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::endXRSession):
* Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
Add WK enum type that corresponds to WebKit::PlatformXRSessionEndReason.
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::endXRSession):
Call the _webViewEndXRSession delegate method that takes in the reason
if it's implemented.
* Source/WebKit/UIProcess/XR/PlatformXRSessionEnums.h: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/279656@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list