[webkit-changes] [WebKit/WebKit] db7a38: Backdrop renderer removal leaves associated layout...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db7a388e601efca2a8cb67e07c4bf00931b78f3a
      https://github.com/WebKit/WebKit/commit/db7a388e601efca2a8cb67e07c4bf00931b78f3a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    A LayoutTests/fast/dynamic/backdrop-remove-crash-expected.txt
    A LayoutTests/fast/dynamic/backdrop-remove-crash.html
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Backdrop renderer removal leaves associated layout box behind
https://bugs.webkit.org/show_bug.cgi?id=275019
<rdar://128067952>

Reviewed by Antti Koivisto.

1. Backdrop render is always anchored to the viewport regardless of where the
associated content renderer is
2. While destroying the content renderer we also remove the backdrop renderer

In order to let invalidateLineLayout kick in (see RenderTreeBuilder::detachFromRenderElement)
we have to make sure the content renderer is not considered as the "destroy root" of the backdrop (see #1).

* LayoutTests/fast/dynamic/backdrop-remove-crash-expected.txt: Added.
* LayoutTests/fast/dynamic/backdrop-remove-crash.html: Added.
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

Canonical link: https://commits.webkit.org/279651@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications