[webkit-changes] [WebKit/WebKit] 228915: [ MacOS Debug ] fast/text/emoji-num-glyphs.html is...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 228915f55f2f7b0def26f44c01d118a163f6fd8b
      https://github.com/WebKit/WebKit/commit/228915f55f2f7b0def26f44c01d118a163f6fd8b
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
    M Source/WebCore/rendering/updating/RenderTreeUpdater.h

  Log Message:
  -----------
  [ MacOS Debug ] fast/text/emoji-num-glyphs.html is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=270195
rdar://problem/123720564

Reviewed by Alan Baradlay.

O(n^2) in whitespace renderer elimination code.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateBeforeDescendants):

Also store ::before as a previous renderer.

(WebCore::RenderTreeUpdater::textRendererIsNeeded):

Track whether we have seen an in-flow renderer already.
We can use this to determine if we need to create a whitespace renderer or not.

(WebCore::RenderTreeUpdater::storePreviousRenderer):

Remember in parent stack whether we have a preceding in-flow sibling.

* Source/WebCore/rendering/updating/RenderTreeUpdater.h:

Canonical link: https://commits.webkit.org/279648@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications