[webkit-changes] [WebKit/WebKit] b473b0: ScopedClearStencilAndMask is error-prone

[Alexey Knyazev]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b473b09ff8c0444d2f48780e6cf6b8af23b942b7
      https://github.com/WebKit/WebKit/commit/b473b09ff8c0444d2f48780e6cf6b8af23b942b7
  Author: Alexey Knyazev <3479527+lexaknyazev at users.noreply.github.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp
    M Source/WebCore/html/canvas/WebGLUtilities.h

  Log Message:
  -----------
  ScopedClearStencilAndMask is error-prone
https://bugs.webkit.org/show_bug.cgi?id=275047

Reviewed by Kimmo Kinnunen.

The clear operation always uses the front stencil
write mask when clearing the stencil buffer.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::startFrame):
* Source/WebCore/html/canvas/WebGLUtilities.h:
(WebCore::ScopedClearStencilAndMask::ScopedClearStencilAndMask):

Canonical link: https://commits.webkit.org/279646@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications