[webkit-changes] [WebKit/WebKit] e1a343: Change some THROW_UNLESS calls into RELEASE_LOG_ER...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1a34394bf941789aafa0a92a13a8c605b6a4f1e
      https://github.com/WebKit/WebKit/commit/e1a34394bf941789aafa0a92a13a8c605b6a4f1e
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-06-02 (Sun, 02 Jun 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h
    M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  -----------
  Change some THROW_UNLESS calls into RELEASE_LOG_ERROR instead.
https://webkit.org/b/275035
rdar://problem/129138876

Reviewed by Brady Eidson.

Change the tabs / activeTab and mainWebView exceptions into error logs.
This also removes webViewsForWebExtensionContext: which is no longer used.
Fixed some test harness code for tabs, so they are in the correct state
and not hitting these ASSERTs in debug runs of the tests.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm:
(WebKit::WebExtensionContext::cookiesGetAllCookieStores):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::getOrCreateTab const): Fix issue with private tabs.
(WebKit::WebExtensionContext::getCurrentTab const):
(WebKit::WebExtensionContext::didCloseTab):
(WebKit::WebExtensionContext::reportWebViewConfigurationErrorIfNeeded const): Simplify
by letting the logging in the webView() method do the work.
(WebKit::WebExtensionContext::openInspectors const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::WebExtensionTab):
(WebKit::WebExtensionTab::window const):
(WebKit::WebExtensionTab::mainWebView const):
(WebKit::WebExtensionTab::isActive const):
(WebKit::WebExtensionTab::isPrivate const):
(WebKit::WebExtensionTab::processes const):
(WebKit::WebExtensionTab::webViews const): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm:
(WebKit::WebExtensionWindow::tabs const):
(WebKit::WebExtensionWindow::activeTab const):
* Source/WebKit/UIProcess/Extensions/WebExtensionTab.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionWindow setTabs:]):
(-[TestWebExtensionWindow openNewTabAtIndex:]):
(-[TestWebExtensionWindow closeTab:windowIsClosing:]):
(-[TestWebExtensionWindow replaceTab:withTab:]):

Canonical link: https://commits.webkit.org/279630@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications