[webkit-changes] [WebKit/WebKit] dc54b6: REGRESSION(279321 at main): js/dom/missing-exception-...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc54b6a653e308433ca5861898c0b19830f17347
      https://github.com/WebKit/WebKit/commit/dc54b6a653e308433ca5861898c0b19830f17347
  Author: Sam Weinig <weinig at apple.com>
  Date:   2024-06-01 (Sat, 01 Jun 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/bindings/js/JSDOMConvertAny.h
    M Source/WebCore/bindings/js/JSDOMConvertVariadic.h

  Log Message:
  -----------
  REGRESSION(279321 at main): js/dom/missing-exception-check-in-convertVariadicArguments.html is crashing : Unchecked exception detected at JSC::VM::verifyExceptionCheckNeedIsSatisfied : ASSERTION FAILED: !m_needExceptionCheck
https://bugs.webkit.org/show_bug.cgi?id=274732

Reviewed by Mark Lam.

Placate the exception checking mechanism by ensure we check for each
conversion in the variadic converter loop.

Also remove unnecessary checks in IDLAny converter.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
    - Re-enable tests.

* Source/WebCore/bindings/js/JSDOMConvertAny.h:
(WebCore::VariadicConverter<IDLAny>::convert):
    - Remove unneeded checks.

* Source/WebCore/bindings/js/JSDOMConvertVariadic.h:
(WebCore::convertVariadicArguments):
    - Add checks for each loop.

Canonical link: https://commits.webkit.org/279617@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications