[webkit-changes] [WebKit/WebKit] c773df: [JSC] non-unified runtime/CachedBytecode.cpp can't...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c773df72044f08bd567d94ecbd59a3b8f0f92a52
      https://github.com/WebKit/WebKit/commit/c773df72044f08bd567d94ecbd59a3b8f0f92a52
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/CachedTypes.cpp
    M Source/JavaScriptCore/runtime/CachedTypes.h

  Log Message:
  -----------
  [JSC] non-unified runtime/CachedBytecode.cpp can't compile after 279198 at main
https://bugs.webkit.org/show_bug.cgi?id=277376

Reviewed by Keith Miller.

After https://commits.webkit.org/279198@main changed some functions in
CachedTypes.h to be constexpr, non-unified CachedBytecode.cpp couldn't
compile because the inline function definitions are still only in
CachedTypes.cpp.

It's not easy to move the inline function definitions to CachedTypes.h
due to the dependencies. Reverted the CachedTypes.{cpp,h} parts of
279198 at main. Removed constexpr of the functions.

* Source/JavaScriptCore/runtime/CachedTypes.cpp:
(JSC::CachedPtrOffsets::offsetOffset):
(JSC::CachedWriteBarrierOffsets::ptrOffset):
(JSC::CachedFunctionExecutableOffsets::codeBlockForCallOffset):
(JSC::CachedFunctionExecutableOffsets::codeBlockForConstructOffset):
(JSC::CachedFunctionExecutableOffsets::metadataOffset):
* Source/JavaScriptCore/runtime/CachedTypes.h:

Canonical link: https://commits.webkit.org/281670@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications