[webkit-changes] [WebKit/WebKit] d36f28: [WebGPU] Render bundle replay should terminate whe...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d36f28d11069d2d679569d9f12f0e9b463e4037c
      https://github.com/WebKit/WebKit/commit/d36f28d11069d2d679569d9f12f0e9b463e4037c
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-277027-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-277027.html
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Render bundle replay should terminate when submit will be invalid
https://bugs.webkit.org/show_bug.cgi?id=277027
rdar://132409084

Reviewed by Dan Glastonbury.

We were continuing to encode commands after a validation error
occurred, which triggered a debug assertion in RenderBundleEncoder::recordCommand

* LayoutTests/fast/webgpu/nocrash/fuzz-277027-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-277027.html: Added.
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(setCommandEncoder):
(WebGPU::RenderBundleEncoder::addResource):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(WebGPU::RenderBundleEncoder::setBindGroup):
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::setVertexBuffer):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::m_maxDrawCount):
(WebGPU::RenderPassEncoder::setCommandEncoder):

Canonical link: https://commits.webkit.org/281653@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications