[webkit-changes] [WebKit/WebKit] b61776: AX: When display:table is applied to tbody element...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b61776dc58608649c3f05a51c5c75338415a2ed6
      https://github.com/WebKit/WebKit/commit/b61776dc58608649c3f05a51c5c75338415a2ed6
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
    A LayoutTests/accessibility/tbody-with-display-table-expected.txt
    A LayoutTests/accessibility/tbody-with-display-table.html
    A LayoutTests/platform/glib/accessibility/tbody-with-display-table-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityTableCell.cpp

  Log Message:
  -----------
  AX: When display:table is applied to tbody elements, VoiceOver cannot find any content in the table
https://bugs.webkit.org/show_bug.cgi?id=277354
rdar://132820485

Reviewed by Chris Fleizach.

This is invalid markup and generally a really strange thing to do, but it renders fine visually, and
other browsers expose a valid accessibility tree, so we should too. This patch fixes this issue by
avoiding the creation of an AccessibilityTable for a RenderTable if the associated element is an
HTMLTableSectionElement, instead allowing the section element (e.g. tbody) to properly be considered a rowgroup.

* LayoutTests/accessibility/tbody-with-display-table-expected.txt: Added.
* LayoutTests/accessibility/tbody-with-display-table.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::createObjectFromRenderer):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityTableCell::parentTable const):

Canonical link: https://commits.webkit.org/281648@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications