[webkit-changes] [WebKit/WebKit] 6aa3e6: Remove redundant test runner state from injected b...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6aa3e639425c8ad5803f215ff7f536756291e3b0
      https://github.com/WebKit/WebKit/commit/6aa3e639425c8ad5803f215ff7f536756291e3b0
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
    M Tools/WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm

  Log Message:
  -----------
  Remove redundant test runner state from injected bundle in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=277055
rdar://132445742

Reviewed by Charlie Wolfe.

This is a step towards getting TestRunner.notifyDone working better with site isolation.
Instead of keeping a state, use the existence of the test runner, which we now need to null check
in a few new places.

* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::dumpToStdErr):
(WTR::InjectedBundle::outputText):
(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::setState):
(WTR::postSynchronousPageMessage):
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::isTestRunning): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::postSynchronousPageMessageReturningBoolean):
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* Tools/WebKitTestRunner/TestInvocation.h:

Canonical link: https://commits.webkit.org/281631@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications