[webkit-changes] [WebKit/WebKit] 9619df: REGRESSION (280925 at main): [ macOS iOS ] TestWebKit...

Timothy Hatcher noreply at github.com
Tue Jul 30 11:15:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9619df3a01b1727e59bf4a819aa93271c7b2732d
      https://github.com/WebKit/WebKit/commit/9619df3a01b1727e59bf4a819aa93271c7b2732d
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
    M Source/WTF/wtf/WeakObjCPtr.h

  Log Message:
  -----------
  REGRESSION (280925 at main): [ macOS iOS ] TestWebKitAPI.WebKit2_WeakObjCPtr.LogicalNegation is a constant failure.
https://webkit.org/b/277285
rdar://problem/132755490

Reviewed by Brian Weinstein.

Revert the WeakObjCPtr changes of 280925 at main. The autorelease pool was retaining the object past the
scope of the WeakObjCPtr in the LogicalNegation test, keeping it non-nil longer than expected.

* Source/WTF/wtf/WeakObjCPtr.h:
(WTF::WeakObjCPtr::operator! const): Switch back to get().
(WTF::WeakObjCPtr::operator bool const): Ditto.

Canonical link: https://commits.webkit.org/281582@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list