[webkit-changes] [WebKit/WebKit] 72ac25: REGRESSION (276531 at main): State dropdown is invisi...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72ac253c4d48099635aa14a321e0c7e1ca267cb2
      https://github.com/WebKit/WebKit/commit/72ac253c4d48099635aa14a321e0c7e1ca267cb2
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block.html
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  REGRESSION (276531 at main): State dropdown is invisible, unable to send feedback via Bunnings.com.au
https://bugs.webkit.org/show_bug.cgi?id=277303
rdar://130520487

Reviewed by Cameron McCormack.

We should not be cancelling animations in the case where we're starting in a hidden subtree, then animating with a keyframe that changes
the display value away from none. Make sure we notify about the newly created keyframe instead.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block.html: Added.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Canonical link: https://commits.webkit.org/281544@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications