[webkit-changes] [WebKit/WebKit] af007e: Adding Glyph display list COLRv0 shared test

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af007e7018ef838fd83c60ea5c96841420245278
      https://github.com/WebKit/WebKit/commit/af007e7018ef838fd83c60ea5c96841420245278
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
    A LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-shared-expected.txt
    A LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-shared.html

  Log Message:
  -----------
  Adding Glyph display list COLRv0 shared test
https://bugs.webkit.org/show_bug.cgi?id=277288
rdar://117866670

Reviewed by Cameron McCormack and Brent Fulgham.

LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared.html tests that glyph
display lists for COLRv0 glyphs are not cached.

However, after a CoreText update, WebKit had to introduce drawPath delegates for DrawGlyphsRecorderCoreText.cpp.
The glyphs that are drawn as a path, and not as a glyph, by CoreText, were failing this test, because they share same
display list, which is dictated by GlyphDisplayListCache::canShareDisplayList .

Since this test is covering the unshared behavior, we should have another test for shared behavior.
The glyph of the character "A" from Ahem-COLR font is a multi-coloured glyph, drawn as a path,
and therefore a Glyph display list containing only items representing this glyph can be shared.

* LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-shared-expected.txt: Added.
* LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-shared.html: Added.

Canonical link: https://commits.webkit.org/281533@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications