[webkit-changes] [WebKit/WebKit] 148e56: http/tests/canvas/ctx.2d-canvas-style-no-document-...

Ryan Reno noreply at github.com
Mon Jul 29 14:13:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 148e56013b4570bf1648002252e2282963b39ab7
      https://github.com/WebKit/WebKit/commit/148e56013b4570bf1648002252e2282963b39ab7
  Author: Ryan Reno <rreno at apple.com>
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-color-no-document-leak-expected.txt
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-color-no-document-leak.html
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-gradient-no-document-leak-expected.txt
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-gradient-no-document-leak.html
    R LayoutTests/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-expected.txt
    R LayoutTests/http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-pattern-no-document-leak-expected.txt
    A LayoutTests/http/tests/canvas/ctx.2d-canvas-style-pattern-no-document-leak.html
    M LayoutTests/platform/win/TestExpectations

  Log Message:
  -----------
  http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=277234
rdar://132725257

Reviewed by Fujii Hironori.

The 2D canvas style leak tests were not robust to the conservative
nature of the JSC garbage collector. This changes the test to use the
document-leak-test.js helper which will allow us to test against a
number of iframes to maximize the chances we will see a Document object
get collected and reduce flakiness of the test.

* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-color-no-document-leak-expected.txt: Added.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-color-no-document-leak.html: Added.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-gradient-no-document-leak-expected.txt: Added.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-gradient-no-document-leak.html: Added.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-no-document-leak-expected.txt: Removed.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-no-document-leak.html: Removed.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-pattern-no-document-leak-expected.txt: Added.
* LayoutTests/http/tests/canvas/ctx.2d-canvas-style-pattern-no-document-leak.html: Added.

Canonical link: https://commits.webkit.org/281523@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list