[webkit-changes] [WebKit/WebKit] 78faea: [JSC] Do not generate string for debugging purpose...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 78faeac776334704f78f76addadd4bd2e4aedbd6
      https://github.com/WebKit/WebKit/commit/78faeac776334704f78f76addadd4bd2e4aedbd6
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT.h
    M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h
    M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp

  Log Message:
  -----------
  [JSC] Do not generate string for debugging purpose in wasm function parser
https://bugs.webkit.org/show_bug.cgi?id=277254
rdar://132711156

Reviewed by Justin Michaud and Yijia Huang.

For debugging purpose, wasm function parser was generating string for each pop, that's wrong approach.
This patch adds ASCIILiteral for that, and generating string at compile time.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::didPopValueFromStack):
* Source/JavaScriptCore/wasm/WasmBBQJIT.h:
* Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp:
(JSC::Wasm::ConstExprGenerator::didPopValueFromStack):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::didPopValueFromStack):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::didPopValueFromStack):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::didPopValueFromStack):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::didPopValueFromStack):

Canonical link: https://commits.webkit.org/281508@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications