[webkit-changes] [WebKit/WebKit] 82f243: AX: role="menu" elements should allow child groups...

Tyler Wilcock noreply at github.com
Sun Jul 28 21:53:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82f243e3dea5201fc1805e6df23120f46ae9471f
      https://github.com/WebKit/WebKit/commit/82f243e3dea5201fc1805e6df23120f46ae9471f
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-07-28 (Sun, 28 Jul 2024)

  Changed paths:
    A LayoutTests/accessibility/menu-with-menuitem-grandchildren-expected.txt
    A LayoutTests/accessibility/menu-with-menuitem-grandchildren.html
    A LayoutTests/platform/glib/accessibility/menu-with-menuitem-grandchildren-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    A LayoutTests/platform/ios/accessibility/menu-with-menuitem-grandchildren-expected.txt
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp

  Log Message:
  -----------
  AX: role="menu" elements should allow child groups with menuitem children
https://bugs.webkit.org/show_bug.cgi?id=276658
rdar://131838275

Reviewed by Chris Fleizach.

Per the ARIA spec:

https://w3c.github.io/aria/#menu

Menus should allow child groups with menuitem children. This patch fixes that.

* LayoutTests/accessibility/menu-with-menuitem-grandchildren-expected.txt: Added.
* LayoutTests/accessibility/menu-with-menuitem-grandchildren.html: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* LayoutTests/platform/ios/accessibility/menu-with-menuitem-grandchildren-expected.txt: Added.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):

Canonical link: https://commits.webkit.org/281481@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list