[webkit-changes] [WebKit/WebKit] 8b5a90: [text-underline-position] Overline should flip sid...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b5a90bd92d223d641d72d87faa1e5663137af03
      https://github.com/WebKit/WebKit/commit/8b5a90bd92d223d641d72d87faa1e5663137af03
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
    M LayoutTests/fast/inline/text-underline-position-right-simple-expected.html
    M Source/WebCore/style/InlineTextBoxStyle.cpp

  Log Message:
  -----------
  [text-underline-position] Overline should flip side even when underline is not painted
https://bugs.webkit.org/show_bug.cgi?id=277056
rdar://132446719

Reviewed by Alan Baradlay.

It doesn't matter whether if the underline is drawn or not, the overline flips side if the underline would be drawn on the "over" side.

Both of these tests need this change to pass:
css/css-text-decor/text-decoration-underline-position-vertical-ja.html [ ImageOnlyFailure ]
css/css-text-decor/text-decoration-underline-position-vertical.html [ ImageOnlyFailure ]

(These tests still fail for different reasons, which is why they're not unskipped)

* LayoutTests/fast/inline/text-underline-position-right-simple-expected.html:

Update the test expectation now that the overline is flipped.

* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::overlineOffsetForTextBoxPainting):

Remove the check for the underline being painted.

Remove an no-op check that assumed that sideways writing mode support `text-underline-position: left | right`.
That check is no-op since 281304 at main which removed underline-position support for sideways text.

Canonical link: https://commits.webkit.org/281434@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications