[webkit-changes] [WebKit/WebKit] ab8fab: [UnifiedPDF] [macOS] Marquee selection does not sh...

Abrar Rahman Protyasha noreply at github.com
Fri Jul 26 15:37:35 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab8fab454e1b9270aa31327dff0f26df1f3f0c71
      https://github.com/WebKit/WebKit/commit/ab8fab454e1b9270aa31327dff0f26df1f3f0c71
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] [macOS] Marquee selection does not show cross cursor
https://bugs.webkit.org/show_bug.cgi?id=277133
rdar://131945594

Reviewed by Aditya Keerthi.

When we update our cursor during a selection drag, we consult the
selection tracking data to know whether we are in a marquee selection.
If so, we present a cross cursor instead of the usual I-beam.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::freezeCursorDuringSelectionDragIfNeeded):
(WebKit::UnifiedPDFPlugin::continueTrackingSelection):

Canonical link: https://commits.webkit.org/281424@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list