[webkit-changes] [WebKit/WebKit] c8ea30: Update _WKWebExtensionTabCreationOptions and _WKWe...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8ea30e4b6ff204b8a058973840720d567406c73
      https://github.com/WebKit/WebKit/commit/c8ea30e4b6ff204b8a058973840720d567406c73
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-07-26 (Fri, 26 Jul 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptionsInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptionsInternal.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm
    M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  -----------
  Update _WKWebExtensionTabCreationOptions and _WKWebExtensionWindowCreationOptions.
https://webkit.org/b/277091
rdar://problem/132511753

Reviewed by Brian Weinstein.

Drop the "waffle" word prefixes from the properties on `_WKWebExtensionTabCreationOptions` and
`_WKWebExtensionWindowCreationOptions`, since the class clearly communicates these are options.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptions.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptionsInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptionsInternal.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeOpenOptionsPage):
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm:
(WebKit::WebExtensionContext::windowsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::duplicate):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, NavigationOpensInNewTab)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Create)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, CreateWithSpecifiedOptions)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, CreateWithRelativeURL)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Duplicate)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, DuplicateWithOptions)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, Create)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURL)):
(TestWebKitAPI::TEST(WKWebExtensionAPIWindows, CreateWithRelativeURLs)):
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager initForExtension:extensionControllerConfiguration:]):
(-[TestWebExtensionWindow openNewTabAtIndex:]):

Canonical link: https://commits.webkit.org/281405@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications