[webkit-changes] [WebKit/WebKit] 5ac02f: Move HTTPS-by-default upgrade logic into CachedRes...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ac02fc13937f5f3d4039091c442d5043e48f8c6
      https://github.com/WebKit/WebKit/commit/5ac02fc13937f5f3d4039091c442d5043e48f8c6
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/loader/ResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.h

  Log Message:
  -----------
  Move HTTPS-by-default upgrade logic into CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=277083
rdar://132494711

Reviewed by Alex Christensen.

Simple code move. This is a direct code move. CachedResourceLoader is a more
appropriate place for this behavior because it is where we performa almost all
other scheme upgrading fr upgrade-insecure-requests, mixed content, and content
extensions. A follow up patch will adjust the logic we use for upgrading
navigations.

No new tests.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::shouldUpgradeRequestforHTTPSOnly const): Deleted.
(WebCore::FrameLoader::upgradeRequestforHTTPSOnlyIfNeeded const): Deleted.
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldUpgradeRequestforHTTPSOnly const):
(WebCore::CachedResourceLoader::upgradeRequestforHTTPSOnlyIfNeeded const):
(WebCore::CachedResourceLoader::requestResource):
* Source/WebCore/loader/cache/CachedResourceLoader.h:

Canonical link: https://commits.webkit.org/281373@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications