[webkit-changes] [WebKit/WebKit] 2644fd: [text-underline-position] Make TextUnderlinePositi...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2644fdabea8a7d1f43206f919db3d18882cd88be
      https://github.com/WebKit/WebKit/commit/2644fdabea8a7d1f43206f919db3d18882cd88be
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareInheritedData.h
    R Source/WebCore/rendering/style/TextUnderlinePosition.cpp
    R Source/WebCore/rendering/style/TextUnderlinePosition.h
    M Source/WebCore/style/InlineTextBoxStyle.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [text-underline-position] Make TextUnderlinePosition use less bits
https://bugs.webkit.org/show_bug.cgi?id=277059
rdar://132452073

Reviewed by Matthieu Dubet.

Use an OptionSet so it fits in 4 bits.

Empty OptionSet represents the auto value.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::textUnderlinePositionToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addToLine):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::textUnderlinePosition const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setTextUnderlinePosition):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/TextUnderlinePosition.cpp: Removed.
* Source/WebCore/rendering/style/TextUnderlinePosition.h: Removed.
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::computedUnderlineOffset):
(WebCore::isAlignedForUnder):
(WebCore::overlineOffsetForTextBoxPainting):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::valueToEmphasisPosition):
(WebCore::Style::valueToUnderlinePosition):
(WebCore::Style::BuilderConverter::convertTextUnderlinePosition):
(WebCore::Style::BuilderConverter::valueToEmphasisPosition): Deleted.

Canonical link: https://commits.webkit.org/281358@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications