[webkit-changes] [WebKit/WebKit] 76bd9a: [Baseline] Fix imported/w3c/web-platform-tests/css...

Alan Baradlay noreply at github.com
Thu Jul 25 08:36:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76bd9ad78d4e916b082bd10c8346d287466216c7
      https://github.com/WebKit/WebKit/commit/76bd9ad78d4e916b082bd10c8346d287466216c7
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [Baseline] Fix imported/w3c/web-platform-tests/css/css-flexbox/flexbox-baseline-multi-line-vert-001-expected.html
https://bugs.webkit.org/show_bug.cgi?id=277081

Reviewed by Antti Koivisto.

"Last line baseline" functions should use the last line with inline content.

(In case of trailing out-of-flow or float content, we need to construct an empty
line (only root inline box is present), but this line should not participate in baseline handling)

* LayoutTests/TestExpectations:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::lastLineWithInlineContent):
(WebCore::LayoutIntegration::LineLayout::contentBoxLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::firstLinePhysicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLinePhysicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineLogicalBaseline const):

Canonical link: https://commits.webkit.org/281353@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list