[webkit-changes] [WebKit/WebKit] 11682f: Enable Wasm BBQ JIT on Windows

[Ian]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11682f9ed717ff578468b07a7cac6ce52826538a
      https://github.com/WebKit/WebKit/commit/11682f9ed717ff578468b07a7cac6ce52826538a
  Author: Ian Grunert <ian.grunert at gmail.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M JSTests/wasm/v8/shared-memory-gc-stress.js
    M Source/JavaScriptCore/llint/WebAssembly.asm
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/WTF/wtf/Gigacage.cpp

  Log Message:
  -----------
  Enable Wasm BBQ JIT on Windows
https://bugs.webkit.org/show_bug.cgi?id=277037

Reviewed by Yusuke Suzuki.

Inside tryAllocateZeroedVirtualPages we were calling
OSAllocator::reserveAndCommit which crashes if it fails to allocate,
instead of tryReserveAndCommit which returns a null pointer. This caused
a number of memory-related wasm test failures.

* JSTests/wasm/v8/shared-memory-gc-stress.js:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::Location::none):
* Source/WTF/wtf/Gigacage.cpp:
(Gigacage::tryAllocateZeroedVirtualPages):

Canonical link: https://commits.webkit.org/281324@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications