[webkit-changes] [WebKit/WebKit] 5a07dd: Expand `imageSizeIsConstrained` to account for `au...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a07ddf5dca4cff92878782ac9719198c57732f7
      https://github.com/WebKit/WebKit/commit/5a07ddf5dca4cff92878782ac9719198c57732f7
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-replaced-content-in-auto-cb-expected.txt
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.h
    M Source/WebCore/rendering/RenderReplaced.cpp

  Log Message:
  -----------
  Expand `imageSizeIsConstrained` to account for `auto` height in order to relayout https://bugs.webkit.org/show_bug.cgi?id=203513

Reviewed by Alan Baradlay.

This aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://chromium.googlesource.com/chromium/src.git/+/934d262005cdf2110da6fe3d1660e6e45cde6925

If our containing block has auto height, we need to relayout.
Add !hasAutoHeightOrContainingBlockWithAutoHeight() to the
condition for 'imageSizeIsConstrained'.

Credits to Alan Baradlay for helping in making it work.

* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
* Source/WebCore/rendering/RenderBox.h:
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-replaced-content-in-auto-cb-expected.txt:

Canonical link: https://commits.webkit.org/281319@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications