[webkit-changes] [WebKit/WebKit] d98aa0: [text-underline-position] `left | right` should be...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d98aa0ee77636d86ee01c1860e79d72d08c4659c
      https://github.com/WebKit/WebKit/commit/d98aa0ee77636d86ee01c1860e79d72d08c4659c
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/style/InlineTextBoxStyle.cpp

  Log Message:
  -----------
  [text-underline-position] `left | right` should be ineffective with sideways text
https://bugs.webkit.org/show_bug.cgi?id=276985
rdar://132384031

Reviewed by Alan Baradlay.

This is tested by:
imported/w3c/web-platform-tests/css/css-text-decor/text-underline-position-001a.html
imported/w3c/web-platform-tests/css/css-text-decor/text-underline-position-001b.html

https://drafts.csswg.org/css-text-decor-4/#underline-left mentions the left | right values behave like auto in horizontal typographic modes.

Take in account horizontal typographic modes + `text-orientation: sideways` before trying to apply left/right alignment.

* LayoutTests/TestExpectations:
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::isAlignedForUnder):
(WebCore::overlineOffsetForTextBoxPainting):

Canonical link: https://commits.webkit.org/281304@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications