[webkit-changes] [WebKit/WebKit] 18a0d3: [GTK][WPE] Constant high idle CPU usage in front o...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18a0d3296eb321ab479d1438b0f8863b9d13ae14
      https://github.com/WebKit/WebKit/commit/18a0d3296eb321ab479d1438b0f8863b9d13ae14
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp

  Log Message:
  -----------
  [GTK][WPE] Constant high idle CPU usage in front of any logged in page on Trello.com
https://bugs.webkit.org/show_bug.cgi?id=252545

Reviewed by Miguel Gomez.

Do not schedule a composition if layers haven't changed and it's not a
force repaint. To know whether platform layer changed, we need to also
track the updates during layer flush and add a way to check the status.
This patch merges updateContentBuffersIncludingSubLayers() and
checkPendingStateChanges() into finalizeCompositingStateFlush() to
upadate the backing stores and check the frame sync and platform updates
in a single layer iteration.

* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer):
(WebCore::CoordinatedGraphicsLayer::checkContentLayerUpdated):
(WebCore::CoordinatedGraphicsLayer::checkPendingStateChanges):
(WebCore::CoordinatedGraphicsLayer::finalizeCompositingStateFlush):
(WebCore::CoordinatedGraphicsLayer::checkPendingStateChangesIncludingSubLayers): Deleted.
(WebCore::CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayers): Deleted.
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::forceRepaint):
(WebKit::LayerTreeHost::renderNextFrame):

Canonical link: https://commits.webkit.org/281288@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications