[webkit-changes] [WebKit/WebKit] 1d776f: Scroll-to-text-fragment is leaked to the loaded pa...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d776f6172680f23acb01d5abca5a41722f2c7df
      https://github.com/WebKit/WebKit/commit/1d776f6172680f23acb01d5abca5a41722f2c7df
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html
    M LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  Scroll-to-text-fragment is leaked to the loaded page through Navigation Timing.
https://bugs.webkit.org/show_bug.cgi?id=276925
rdar://124717009

Reviewed by Ryosuke Niwa.

We need to strip the fragment from the URL earlier so that the full URL does not end up
in the performance metrics, leaking the fragment that should be invisible to the page.

WPT test will need to be upstreamed after this patch lands.

* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment-target.html:
* LayoutTests/imported/w3c/web-platform-tests/scroll-to-text-fragment/scroll-to-text-fragment.html:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::setURL):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setMainFrameURLFragment):
* Source/WebCore/page/Page.h:
(WebCore::Page::mainFrameURLFragment const):

Canonical link: https://commits.webkit.org/281273@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications