[webkit-changes] [WebKit/WebKit] b9a1d4: Error in run-safari when build is unavailable is q...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9a1d40b83d224955402d7a49e2fb5e6c96fb32a
      https://github.com/WebKit/WebKit/commit/b9a1d40b83d224955402d7a49e2fb5e6c96fb32a
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M Tools/Scripts/run-mangleme-tests
    M Tools/Scripts/run-pageloadtest
    M Tools/Scripts/run-qt-wpe-minibrowser
    M Tools/Scripts/run-safari
    M Tools/Scripts/run-webkit-app
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  Error in run-safari when build is unavailable is quite obtuse
https://bugs.webkit.org/show_bug.cgi?id=276968

Reviewed by Elliott Williams.

- Adds an additional check to see if the build products directory for the
  specified configuration is available, and fails with a specific message
  if it is not.

- Adds information about the configuration being used with explanatory text
  about how that configuration got selected, when a build product is not
  available or a dylib couldn't be found.

- Adds a suggestion to run `build-webkit` as a next step.

New error experience looks like:

```
    > Tools/Scripts/run-safari --release
    No build products could be found for specified build:
      configuration: "Release" [via argument, `--release`]
      products:      /Users/person/Code/WebKit/WebKitBuild/Release

    To build this configuration, use the command `Tools/Scripts/build-webkit --release`.

    Once that completes, re-run this command.
```

* Tools/Scripts/run-mangleme-tests:
* Tools/Scripts/run-pageloadtest:
* Tools/Scripts/run-qt-wpe-minibrowser:
* Tools/Scripts/run-safari:
* Tools/Scripts/run-webkit-app:
    Update for rename from checkFrameworks to checkBuild.

* Tools/Scripts/webkitdirs.pm:
(determineConfiguration):
(determineXcodeSDKPlatformName):
(determinePassedConfiguration):
(setConfiguration):
    Track how configuration and xcode platform got selected so
    it can be used in case of an error.
(scriptPathForName):
    Helper to get path for script name.
(launcherPath):
    Use new scriptPathForName() helper.
(debugSafari):
    Update for rename.
(checkBuild):
    Adds check for products directory existing and expands error text.

Canonical link: https://commits.webkit.org/281270@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications