[webkit-changes] [WebKit/WebKit] 3bbfe9: [text-underline-position] Parse `from-font | under...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bbfe9b1ec474ad7874249db7d0678cef813f048
      https://github.com/WebKit/WebKit/commit/3bbfe9b1ec474ad7874249db7d0678cef813f048
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-underline-position-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-underline-position-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-position-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareInheritedData.h
    A Source/WebCore/rendering/style/TextUnderlinePosition.cpp
    A Source/WebCore/rendering/style/TextUnderlinePosition.h
    M Source/WebCore/style/InlineTextBoxStyle.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [text-underline-position] Parse `from-font | under` combined with `left | right`
https://bugs.webkit.org/show_bug.cgi?id=276922
rdar://132292219

Reviewed by Darin Adler.

Allow chaining `from-font | under` before or after `left | right`.

Spec: https://drafts.csswg.org/css-text-decor-4/#text-underline-position-property

This only implements parsing and does not change painting when combinations are used.

* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-underline-position-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-underline-position-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-underline-position-expected.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTextUnderlinePosition):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addToLine):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::textUnderlinePosition const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setTextUnderlinePosition):
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/TextUnderlinePosition.cpp: Added.
(WebCore::operator<<):
* Source/WebCore/rendering/style/TextUnderlinePosition.h: Added.
(WebCore::TextUnderlinePosition::isAuto):
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::computedUnderlineOffset):
(WebCore::isAlignedForUnder):
(WebCore::overlineOffsetForTextBoxPainting):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextUnderlinePosition):

Canonical link: https://commits.webkit.org/281260@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications