[webkit-changes] [WebKit/WebKit] aa9297: Implement getPushPermissionState in webpushd

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa9297075ed0cd9f3731773954d4ce506658e308
      https://github.com/WebKit/WebKit/commit/aa9297075ed0cd9f3731773954d4ce506658e308
  Author: Ben Nham <nham at apple.com>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp
    M Source/WebKit/webpushd/PushClientConnection.h
    M Source/WebKit/webpushd/PushClientConnection.messages.in
    M Source/WebKit/webpushd/PushClientConnection.mm
    M Source/WebKit/webpushd/WebPushDaemon.h
    M Source/WebKit/webpushd/WebPushDaemon.mm
    M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h
    M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
    M Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm

  Log Message:
  -----------
  Implement getPushPermissionState in webpushd
https://bugs.webkit.org/show_bug.cgi?id=276929
rdar://132296992

Reviewed by Brady Eidson.

This implements the getPushPermissionState IPC in webpushd, which is part of a larger project in
which we are moving push and notifications permissions management from the embedder to webpushd.

Testing is currently via a new webpushtool command. We'll add integration tests in the future once
Brady commits UserNotifications mocks in a future patch.

I also had to do some webpushtool cleanup to make that possible, and a lot more webpushtool cleanup
should probably occur, but I'll defer that work to a future patch.

* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::getPushPermissionState):
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::webPushDaemonConnectionConfiguration const):
* Source/WebKit/webpushd/PushClientConnection.h:
* Source/WebKit/webpushd/PushClientConnection.messages.in:
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::updateConnectionConfiguration):
(WebPushD::PushClientConnection::hostAppCodeSigningIdentifier):
(WebPushD::PushClientConnection::getPushPermissionState):
* Source/WebKit/webpushd/WebPushDaemon.h:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::getPushPermissionState):
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:
* Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm:
(WebPushTool::Connection::create):
(WebPushTool::Connection::Connection):
(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::sendPushMessage):
(WebPushTool::Connection::getPushPermissionState):
(WebPushTool::Connection::sendAuditToken):
(WebPushTool::Connection::startAction): Deleted.
(WebPushTool::Connection::startDebugStreamAction): Deleted.
(WebPushTool::Connection::connectionDropped): Deleted.
(WebPushTool::Connection::messageReceived): Deleted.
* Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:
(printUsageAndTerminate):
(WebKit::WebPushToolMain):

Canonical link: https://commits.webkit.org/281258@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications