[webkit-changes] [WebKit/WebKit] 4aa16f: [COCOA] Remove usage of libwebrtc network manager ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4aa16f26e567b8eccc6b55f4406f979c09e9fe33
      https://github.com/WebKit/WebKit/commit/4aa16f26e567b8eccc6b55f4406f979c09e9fe33
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
    M Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h
    M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.cpp
    M Source/WebKit/NetworkProcess/webrtc/LibWebRTCSocketClient.h
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h
    M Source/WebKit/Shared/RTCNetwork.cpp
    M Source/WebKit/Shared/RTCNetwork.h
    M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp

  Log Message:
  -----------
  [COCOA] Remove usage of libwebrtc network manager in NetworkRTCMonitor
https://bugs.webkit.org/show_bug.cgi?id=276776
rdar://132001134

Reviewed by Eric Carlson.

We remove usage of libwebrtc network manager from NetworkRTCMonitor.
Instead we reimplement the functionality through POSIX API, following what is done in libwebrtc.
This version is simpler as WebKit is only exposing interfaces that are actually in use (the default interface plus the interface that the page may use if different from the default one).
A future patch should use more nw API for Cocoa platforms.

Manually tested.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::networkManager):
(WebKit::NetworkManager::NetworkManager):
(WebKit::NetworkManager::addListener):
(WebKit::NetworkManager::removeListener):
(WebKit::addressFromInterface):
(WebKit::interfaceAdapterType):
(WebKit::gatherNetworkMap):
(WebKit::connectToRemoteAddress):
(WebKit::getSocketLocalAddress):
(WebKit::getDefaultIPAddress):
(WebKit::NetworkManager::updateNetworks):
(WebKit::isEqual):
(WebKit::hasNetworkChanged):
(WebKit::sortNetworks):
(WebKit::NetworkManager::onGatheredNetworks):
(WebKit::NetworkRTCMonitor::ref):
(WebKit::NetworkRTCMonitor::deref):
(WebKit::NetworkManagerWrapper::addListener): Deleted.
(WebKit::NetworkManagerWrapper::removeListener): Deleted.
(WebKit::NetworkManagerWrapper::onNetworksChanged): Deleted.
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h:
* Source/WebKit/Shared/RTCNetwork.h:

Canonical link: https://commits.webkit.org/281185@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications