[webkit-changes] [WebKit/WebKit] 119c3f: [Navigation] Fix navigate-event/navigate-history-g...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 119c3f505360a74d63d6747fd6167c8af7d416ff
      https://github.com/WebKit/WebKit/commit/119c3f505360a74d63d6747fd6167c8af7d416ff
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-07-22 (Mon, 22 Jul 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0-expected.txt
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/loader/FrameLoaderTypes.h
    M Source/WebCore/loader/NavigationScheduler.cpp
    M Source/WebCore/page/History.cpp
    M Source/WebCore/page/History.h

  Log Message:
  -----------
  [Navigation] Fix navigate-event/navigate-history-go-0.html
https://bugs.webkit.org/show_bug.cgi?id=276863

Reviewed by Darin Adler.

Fix navigate-history-go-0.html by adding a new state to NavigationHistoryBehavior to identify
reloads so the determined navigation type will be "reload". This is needed because go(0) is not
identified as a traditional reload by FrameLoader.

This PR also corrects an unaddressed review comment from 281135 at main and replaces StateObjectType with
NavigationHistoryBehavior.

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-history-go-0-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::determineNavigationType):
(WebCore::FrameLoader::loadURL):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/FrameLoaderTypes.h:
* Source/WebCore/loader/NavigationScheduler.cpp:
* Source/WebCore/page/History.cpp:
(WebCore::History::stateObjectAdded):
* Source/WebCore/page/History.h:
(WebCore::History::pushState):
(WebCore::History::replaceState):

Canonical link: https://commits.webkit.org/281182@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications