[webkit-changes] [WebKit/WebKit] 5081bf: [iOS] Adjust the viewport expansion heuristic to b...
Wenson Hsieh
noreply at github.com
Sun Jul 21 07:42:46 PDT 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5081bf058b8d9343d7f7227b486e02e47e31ed2d
https://github.com/WebKit/WebKit/commit/5081bf058b8d9343d7f7227b486e02e47e31ed2d
Author: Wenson Hsieh <wenson_hsieh at apple.com>
Date: 2024-07-21 (Sun, 21 Jul 2024)
Changed paths:
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
[iOS] Adjust the viewport expansion heuristic to better detect full-page modal containers
https://bugs.webkit.org/show_bug.cgi?id=276849
rdar://132160090
Reviewed by Abrar Rahman Protyasha.
Make some more adjustments to the layout viewport expansion heuristic:
- When hit-testing to see if there's a large modal container covering most of the viewport,
perform an area-based hit-test in the entire viewport. This avoids a false negative in the case
where the center of the viewport hit-tests to a smaller fixed-position container that does not
cover the screen.
- Don't re-expand to double height after shrinking, to avoid cases where the viewport height might
thrash too frequently.
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateLayoutViewportHeightExpansionTimerFired):
Canonical link: https://commits.webkit.org/281172@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list