[webkit-changes] [WebKit/WebKit] fa4ff9: [Flex] Fix css/css-flexbox/align-items-baseline-co...

Alan Baradlay noreply at github.com
Sat Jul 20 18:14:04 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa4ff92490ae5b91b1d12b78777dc8fa36ba4f97
      https://github.com/WebKit/WebKit/commit/fa4ff92490ae5b91b1d12b78777dc8fa36ba4f97
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-07-20 (Sat, 20 Jul 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/css3/flexbox/flex-align-baseline-expected.txt
    M LayoutTests/css3/flexbox/flex-align-baseline.html
    M LayoutTests/css3/flexbox/multiline-align-self.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-006-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-008-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-line-clamp-002.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-line-clamp-003.tentative-expected.txt
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [Flex] Fix css/css-flexbox/align-items-baseline-column-vert.html
https://bugs.webkit.org/show_bug.cgi?id=276757

Reviewed by Antti Koivisto.

Remove legacy behavior (changed at https://drafts.csswg.org/css-flexbox-1/#change-2016-baseline-alignment)

(Sadly while we match other browsers now, css/css-flexbox/align-items-baseline-column-vert.html still fails as the ref side uses grid)

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignmentForFlexItem const):

Canonical link: https://commits.webkit.org/281168@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list