[webkit-changes] [WebKit/WebKit] b425c6: [Viewer Mode] Can't exit PiP after switching tabs ...

Jer Noble noreply at github.com
Fri Jul 19 13:28:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b425c69887c7c8641cbd832216073f16bbf0957e
      https://github.com/WebKit/WebKit/commit/b425c69887c7c8641cbd832216073f16bbf0957e
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-07-19 (Fri, 19 Jul 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.mm

  Log Message:
  -----------
  [Viewer Mode] Can't exit PiP after switching tabs in viewer mode
https://bugs.webkit.org/show_bug.cgi?id=276820
rdar://131791367

Reviewed by Andy Estes and Eric Carlson.

Returning to InWindowFullscreen mode goes through the "Element Fullscreen" path,
which fails if there's no user gesture activation. Ensure a user gesture is present
when a command from the UI Process requests a specific fullscreen mode.

* Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.mm:
(WebCore::VideoPresentationModelVideoElement::requestFullscreenMode):

Canonical link: https://commits.webkit.org/281145@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list